NSIS-ka
A free C++ implementation of NSIS protocols

Opened 11 years ago

#20 new defect

Revisit Locking

Reported by: hiwi-laier Owned by: hiwi-laier
Priority: major Milestone:
Component: ProtLib Version:
Keywords: Cc:

Description

Locking in transport classes (and places where this may have been reproduced).

lock();
assoc = connmap.lookup(addr);
unlock();
if (assoc)

We have not obtained a reference to the object referenced as "assoc" on the stack. This means another thread could delete this object from under us.

Keep this in mind in case any segfaults or data corruptions show up later.

Change History (0)

Note: See TracTickets for help on using tickets.